Circle CI: Run DevTools Playwright e2e tests #23019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
|
Comparing: bcd24a6...2f05c55 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
bvaughn
force-pushed
the
devtools-run-e2e-tests-in-ci
branch
from
6d692d5
to
a2e1035
Compare
bvaughn
changed the title
bvaughn
force-pushed
the
devtools-run-e2e-tests-in-ci
branch
from
a2e1035
to
e83afab
Compare
|
Looks like the new command is mostly working on Circle CI, except for a browser+environment issue: Maybe this is related to the version of Node our tests are running on? microsoft/playwright#4033 Although judging from the output of our setup job, we're using a new enough version (v14.17.6): Let me try to add a specific diff --git a/.circleci/config.yml b/.circleci/config.yml
index 2b8b694d0..60c5ed2e0 100644
--- a/.circleci/config.yml
+++ b/.circleci/config.yml
@@ -212,6 +212,9 @@ jobs:
- run:
name: Install Packages
command: yarn --frozen-lockfile --cache-folder ~/.cache/yarn
+ - run:
+ name: Playwright install
+ command: npx playwright install
- run:
environment:
RELEASE_CHANNEL: experimental |
bvaughn
force-pushed
the
devtools-run-e2e-tests-in-ci
branch
from
e83afab
to
bcca4cf
Compare
bvaughn
force-pushed
the
devtools-run-e2e-tests-in-ci
branch
from
bcca4cf
to
2f05c55
Compare
|
Yay it worked! 🥳 |
jstejada
approved these changes
Jan 3, 2022
jstejada
approved these changes
Jan 4, 2022
zhengjitf
pushed a commit
to zhengjitf/react
that referenced
this pull request
Apr 15, 2022
nevilm-lt
pushed a commit
to nevilm-lt/react
that referenced
this pull request
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's run the new DevTools e2e tests on Circle CI. They seem solid but if this turns out to be flaky or cause problems we can disable them.
Resolves #22646.
Successful run
Screen.Recording.2021-12-22.at.2.08.20.PM.mov
Failed run
Screen.Recording.2021-12-22.at.2.10.00.PM.mov